test: aligned serialization tests with the new json compare logic, ad…

…ding whitespace into string literals
bugsnag · Nov 25, 2021 · 870f36c · 870f36c
1 parent 15975d9
commit 870f36c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java b/bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
@@ -771,7 +771,8 @@ void notifyInternal(@NonNull Event event,
 
         // Run on error tasks, don't notify if any return false
         if (!callbackState.runOnErrorTasks(event, logger)
-                || (onError != null && !onError.onError(event))) {
+                || (onError != null
+                && !onError.onError(event))) {
             logger.d("Skipping notification - onError task returned false");
             return;
         }

diff --git a/bugsnag-android-core/src/test/java/com/bugsnag/android/AppDataCollectorSerializationTest.kt b/bugsnag-android-core/src/test/java/com/bugsnag/android/AppDataCollectorSerializationTest.kt
@@ -31,7 +31,7 @@ internal class AppDataCollectorSerializationTest {
             val memoryTrimState = MemoryTrimState()
 
             // populate summary fields
-            config.appType = "ReactNative"
+            config.appType = "React Native"
             config.releaseStage = "test-stage"
             config.appVersion = "1.2.3"
             config.versionCode = 55

diff --git a/bugsnag-android-core/src/test/java/com/bugsnag/android/BreadcrumbSerializationTest.kt b/bugsnag-android-core/src/test/java/com/bugsnag/android/BreadcrumbSerializationTest.kt
@@ -17,7 +17,7 @@ internal class BreadcrumbSerializationTest {
             val timestamp = Date(0)
             return generateSerializationTestCases(
                 "breadcrumb",
-                Breadcrumb("helloworld", BreadcrumbType.MANUAL, mutableMapOf(), timestamp, NoopLogger),
+                Breadcrumb("hello world", BreadcrumbType.MANUAL, mutableMapOf(), timestamp, NoopLogger),
                 Breadcrumb(
                     "metadata",
                     BreadcrumbType.PROCESS,

diff --git a/bugsnag-android-core/src/test/java/com/bugsnag/android/EventSerializationTest.kt b/bugsnag-android-core/src/test/java/com/bugsnag/android/EventSerializationTest.kt
@@ -57,11 +57,11 @@ internal class EventSerializationTest {
                 createEvent {
                     it.addMetadata("app", "foo", 55)
                     it.addMetadata("device", "bar", true)
-                    it.addMetadata("wham", "some_key", "Avalue")
+                    it.addMetadata("wham", "some_key", "A value")
                     it.setUser(null, null, "Jamie")
 
                     val crumb = Breadcrumb(
-                        "helloworld",
+                        "hello world",
                         BreadcrumbType.MANUAL,
                         mutableMapOf(),
                         Date(0),