-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate changes in app.isLaunching to the NDK layer #1180
Merged
fractalwrench
merged 1 commit into
integration/road-1175-identify-crashes-on-launch
from
PLAT-5979/ndk-is-launching
Mar 12, 2021
Merged
Propagate changes in app.isLaunching to the NDK layer #1180
fractalwrench
merged 1 commit into
integration/road-1175-identify-crashes-on-launch
from
PLAT-5979/ndk-is-launching
Mar 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5979/ndk-is-launching
branch
from
March 9, 2021 17:22
700f6af
to
d43c282
Compare
fractalwrench
changed the title
feat: propagate app.isLaunching to NDK layer
Propagate changes in app.isLaunching to the NDK layer
Mar 10, 2021
fractalwrench
force-pushed
the
PLAT-5979/ndk-is-launching
branch
from
March 11, 2021 10:52
d43c282
to
fc56ed1
Compare
kstenerud
requested changes
Mar 11, 2021
fractalwrench
force-pushed
the
PLAT-5979/ndk-is-launching
branch
2 times, most recently
from
March 11, 2021 15:32
e843b4d
to
6f0afd3
Compare
fractalwrench
force-pushed
the
PLAT-5979/ndk-is-launching
branch
2 times, most recently
from
March 11, 2021 16:24
9a95120
to
830b3ed
Compare
twometresteve
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so long as @kstenerud is now happy.
kstenerud
approved these changes
Mar 12, 2021
fractalwrench
force-pushed
the
PLAT-5979/ndk-is-launching
branch
from
March 12, 2021 08:52
830b3ed
to
8c1e33b
Compare
fractalwrench
force-pushed
the
PLAT-5979/ndk-is-launching
branch
from
March 12, 2021 09:56
8c1e33b
to
65ed888
Compare
fractalwrench
merged commit Mar 12, 2021
7a4f8e8
into
integration/road-1175-identify-crashes-on-launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently
app.isLaunching
is only set on JVM error reports. This changeset adds it to NDK error reports and adds verification that it has been set for both in the form of E2E tests.Changeset
LaunchCrashTracker
extendsBaseObservable
and notifies its observers whenisLaunching
is set to falseNativeBridge
which communicates with the NDK layer invokes a JNI function which updatesbsg_event->app.is_launching
to falseinForeground
rather thanisLaunching
value was serializedis_launching
tobsg_app_info
structbugsnag_app_get_is_launching/bugsnag_app_set_is_launching
functions to allow users to alter the value in an on_error callback.Struct migration
When a fatal NDK error occurs, the memory contents of
bsg_event
struct is persisted on disk and then loaded again the next launch. Because the struct can change between releases, old payloads need to be migrated to the new struct. This has been achieved by the following changes:BUGSNAG_EVENT_VERSION
is 4 and load it intobugsnag_report_v4
, which is a copy of the previous struct definitionBUGSNAG_EVENT_VERSION
in the serializer and migrated thebsg_app_info
valuesapp.is_launching
to false if no information was available in the structTesting
app.isLaunching
is set appropriately in JVM/NDK E2E tests