Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projectPackages field to error payloads #1226

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds projectPackages to the event payload. This is used to improve deobfuscation when a class in the projectPackages package has been minified with ProGuard - inProject calculations do not work well here as the class name will be mangled.

Testing

  • Added unit tests to ensure projectPackages is serialized
  • Updated smoke tests to add E2E assertions
  • Tested errors sent in obfuscated example app

@fractalwrench fractalwrench marked this pull request as ready for review April 21, 2021 09:45
@fractalwrench fractalwrench changed the title Add projectPackages to event payload Add projectPackages field to error payloads Apr 21, 2021
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1514.08 1414.46
arm64_v8a 402.18 299.78
armeabi 381.69 279.29
armeabi_v7a 365.32 262.92
x86 439.02 336.62
x86_64 422.64 320.24

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants