Unity: add methods for setting autoNotify and autoDetectAnrs #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
changed the title
fractalwrench
force-pushed
the
android-auto-notify
branch
from
f76d8e2
to
a27c2af
Compare
kstenerud
approved these changes
May 4, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
android-auto-notify
branch
from
aa70a7f
to
c08e2a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds non-public methods to support the autoNotify and autoDetectAnrs APIs on Unity, which allow automatic error detection to be switched off after Bugsnag has been initilized: https://docs.bugsnag.com/platforms/unity/configuration-options/#autodetectanrs
Changeset
NativeInterface.setAutoDetectAnrsandNativeInterface.setAutoNotify, which will be invoked from UnityAnrPluginandNdkPluginto allow for signal handlers etc to be unregistered in a call toPlugin#unload()ExceptionHandlerto allow uninstallingClientandPluginClientto ensure that any change inautoNotify/autoDetectAnrsis propagated to all automatic error detection sourcesTesting
Added unit tests throughout, and added E2E tests which verify that ANRs/JVM/NDK errors are recorded appropriately when automatic capture is enabled/disabled.