Fix segfaults in NDK instrumentation tests #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-7000/fix-ndk-test-crash
branch
from
b4a0955
to
f4bfb0b
Compare
kstenerud
approved these changes
Jul 15, 2021
fractalwrench
force-pushed
the
PLAT-7000/fix-ndk-test-crash
branch
from
9f272ec
to
a5561dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes segfaults in the NDK instrumentation tests and runs them automatically on CI.
Changeset
mallocwithcallocso that tests always use consistent data that has been wiped to 0generate_basic_reportfunction. This was resulting in unpredictable segfaults when running the migration tests as test code was attempting to fit old structs intobugsnag_eventAdditionally, tests such as
BreadcrumbStateSerializationTestwhich verify the native layer serializes JSON correctly have been altered. The C layer is now only responsible for serializing the JSON, and passes the result to the JUnit test. This makes the result easier to identify, and circumvents segfaults which were happening in the test assertions.