-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address pre-existing StrictMode violations #1328
Merged
fractalwrench
merged 3 commits into
integration/road-757-strictmode
from
PLAT-7027/refactor-strictmode-violations
Jul 26, 2021
Merged
Address pre-existing StrictMode violations #1328
fractalwrench
merged 3 commits into
integration/road-757-strictmode
from
PLAT-7027/refactor-strictmode-violations
Jul 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
Plat 7027/refactor strictmode violations
Address pre-existing StrictMode violations
Jul 22, 2021
fractalwrench
force-pushed
the
PLAT-7027/refactor-strictmode-violations
branch
7 times, most recently
from
July 22, 2021 14:34
4791839
to
b4b8eeb
Compare
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
PLAT-7027/refactor-strictmode-violations
branch
from
July 22, 2021 15:50
b4b8eeb
to
de220a4
Compare
fractalwrench
commented
Jul 22, 2021
.../fixtures/mazerunner/app/src/main/java/com/bugsnag/android/mazerunner/StartupANRBehaviour.kt
Show resolved
Hide resolved
lemnik
reviewed
Jul 23, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/BugsnagStateModule.kt
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
PLAT-7027/refactor-strictmode-violations
branch
2 times, most recently
from
July 26, 2021 10:18
65aa21f
to
3c24ea7
Compare
lemnik
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fractalwrench
force-pushed
the
PLAT-7027/refactor-strictmode-violations
branch
from
July 26, 2021 11:27
ea340d9
to
091fcee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Addresses some pre-existing StrictMode violations by moving affected code onto background threads where possible, and only calling
Future#get()
when the result is absolutely required.Changeset
DeviceIdStore
no longer callsfile.exists()
asfile.createNewFile()
is sufficient)ImmutableConfig
so thatpersistenceDirectory
is a lazy property. This avoids callingcontext#getCacheDir()
on the main threadClient
constructor by extracting the construction and configuration of objects into relatedDependencyModules
which form a dependency graph. These make it simpler to run I/O on background threads and also lay the framework for greater dependency injection in future.device.freeDisk
calculation to run on IO threadTesting
Relied on existing test coverage. Confirmed the strictmode violations are resolved by enabling all penalties in the example app.