Parse Breadcrumbs for OnSend Callbacks #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7610/parsebreadcrumbs-for-onsend
branch
from
e069b5a
to
4c857f0
Compare
bugsnag-android-core/src/main/java/com/bugsnag/android/BreadcrumbType.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/test/java/com/bugsnag/android/BreadcrumbSerializationTest.kt
Show resolved
Hide resolved
lemnik
force-pushed
the
PLAT-7610/parsebreadcrumbs-for-onsend
branch
from
4c857f0
to
154555e
Compare
kattrali
reviewed
Nov 19, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/BugsnagEventMapper.kt
Outdated
Show resolved
Hide resolved
lemnik
force-pushed
the
PLAT-7610/parsebreadcrumbs-for-onsend
branch
from
154555e
to
290b442
Compare
kattrali
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Parse
BreadcrumbInternalobjects (which will be wrapped inBreadcrumbobjects) from stored events, so that they can be processed by registeredOnSendCallbacks.Testing
Added a deserialization test to
BreadcrumbSerializationTest