Avoid unnecessary network connectivity change breadcrumb on API <24 #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-7614/connectivity-legacy
branch
from
ccb3cd8
to
28aef70
Compare
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
PLAT-7614/connectivity-legacy
branch
from
28aef70
to
5fd32cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Builds on #1540 so that an unnecessary network change breadcrumb is not logged on devices running API <24. The
CONNECTIVITY_ACTIONintent is sticky so will always trigger the broadcast receiver.Testing
Verified that E2E tests don't fail on Android 6, and otherwise relied on existing test coverage + manual testing.