Fix React Native events that override the apiKey #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7916/deserialize-reactnative-apikey
branch
from
3a953cb
to
6cf9afd
Compare
lemnik
force-pushed
the
PLAT-7916/deserialize-reactnative-apikey
branch
from
6cf9afd
to
d819810
Compare
imjoehaines
reviewed
Jan 31, 2022
| ) | ||
|
|
||
| val event = EventDeserializer(client, emptyList()).deserialize(map) | ||
| assertEquals("abc123", event.apiKey) |
There was a problem hiding this comment.
Seems worth adding an assertion when there is no API key in the map (presumably it's null in that case?)
lemnik
force-pushed
the
PLAT-7916/deserialize-reactnative-apikey
branch
from
d819810
to
d88a237
Compare
imjoehaines
approved these changes
Jan 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allow React Native applications to override the
Event.apiKeyin their callbacks.Changeset
If the
apiKeyfield is present and not empty, override it in theEventbefore delivery to the Android layerTesting
Additional unit tests added, and manually tested with the example React Native app.