Ensure handling_crash flag is atomic #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
PLAT-8095-atomic-handling-crash
branch
from
0b750ce
to
4e7dd67
Compare
kstenerud
force-pushed
the
PLAT-8095-atomic-handling-crash
branch
from
4e7dd67
to
45e04f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The flag to mark that a native crash is being handled was not atomic, leaving room for a race condition should two threads trigger a native crash at the same time.
Design
Use atomics to ensure that no race condition is possible.
Testing
Reran all tests.