Optimise DependencyModule.resolveDependencies #1680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve Bugsnag startup performance by optimising
DependencyModule.resolveDependencies
Design
Removed
future
The
future
property delegate had two undesirable impacts:Function
, and a wrapper for the constructionFunction
)DependencyModule
objects could be allocated there was a reflection overhead brought about by theKProperty
objectsRemoved the use of
Future.get
DependencyModule.resolveDependencies
always waited for its background task to complete before returning. This PR moves the waiting to the first references of the values, by hiding the properties behind aresolveValueOf
function which will wait (if required) for the background task to complete.Testing
Relied on existing tests