Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dispatch_semaphore instead of NSCondition #1008

Merged

Conversation

nickdowell
Copy link
Contributor

Goal

Fixes the following issue observed in device logs for older iOS versions:

*** -[NSCondition dealloc]: condition (<NSCondition: 0x17411c200> '(null)') deallocated while still in use
*** Break on _NSLockError() to debug.

Also fixes an issue which can arise if the callback is called before waitUntilDate: - this does not work as expected with an NSCondition and results in a 2 second timeout.

GCD semaphores fix both of these issues.

Testing

Verified manually using example app.

@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size increased by 232 bytes from 1,084,304 to 1,084,536

Generated by 🚫 Danger

@nickdowell nickdowell merged commit a9d6d5f into integration/identify-crashes-on-launch Feb 22, 2021
@nickdowell nickdowell deleted the nickdowell/fix-sync-sending branch February 22, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants