Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix os_proc_available_memory runtime link error on Mac Catalyst #1025

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Mar 9, 2021

Goal

Bugsnag was causing Mac Catalyst apps to exit with a dyld error due to os_proc_available_memory not being available on macOS:

dyld: Symbol not found: _os_proc_available_memory

Annoyingly, __builtin_available(iOS 13.0, ...) does not cater for APIs that are available on iOS but not Catalyst.

Changeset

The code is now compiled out when building for Mac Catalyst (TARGET_OS_MACCATALYST)

Enabled Mac Catalyst for the objective-c-ios sample app to allow easier testing.

Testing

Tested manually in the sample app.

@nickdowell nickdowell marked this pull request as ready for review March 9, 2021 15:12
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,084,896 bytes

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants