Add unit tests on ARM #1125
Merged
Add unit tests on ARM #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twometresteve
force-pushed
the
tms/m1
branch
4 times, most recently
from
6b8fd88
to
55c47b3
Compare
nickdowell
reviewed
Jun 22, 2021
.buildkite/pipeline.full.yml
Outdated
| skip: Pending PLAT-6822 | ||
| depends_on: | ||
| - cocoa_fixture | ||
| timeout_in_minutes: 10 |
There was a problem hiding this comment.
This will need to be changed to 60 when skip: is removed
nickdowell
approved these changes
Jun 22, 2021
Yes, that's a fair point in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds unit tests on ARM Macs to CI and placeholder steps for the e2e tests.
Design
Although tested, the e2e tests cannot be enabled at this stage due to the screen lock in place. This will be reviewed in time.
Changeset
To avoid conflicts in uploaded file names, I've changed the pipeline to upload Intel/ARM apps as different names. This was easier than changing the rest of the framework to run off of variable app names.
Testing
Covered by CI. Skipped e2e test steps were successfully tested during development by manually logging into the server whilst running.