[PLAT-7101 ] Fix ThreadSanitizer data race in BugsnagBreadcrumbs #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
kstenerud
approved these changes
Aug 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a data race detected by ThreadSanitizer.
Changeset
Wraps access to
nextFileNumberin a@synchronized (self)block to prevent simultaneous read and write.Skips
testCrashReportWriterConcurrencywhen ThreadSanitizer is enabled because suspending threads causes deadlocks in TSan's code (which uses locking primitives.)Testing
Reproduced issue by running
BugsnagBreadcrumbsTestwith ThreadSanitizer enabled, confirmed that data race is no longer reported.