Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional logging #1166

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Additional logging #1166

merged 2 commits into from
Aug 12, 2021

Conversation

nickdowell
Copy link
Contributor

Goal

Add some additional logging to help track down the cause of some intermittent test failures, after discussion with @twometresteve

Changeset

  • Adds verbose logging to the mac E2E test fixture which should help determine whether some failures are caused by the app losing focus or failing to receive all key presses.
  • Attaches the invalid JSON from testCrashReportWriterConcurrency upon failure, to allow further investigation (have not been able to reproduce this locally.)

Testing

Tested locally

@nickdowell nickdowell changed the title Nickdowell/test logging Additional logging Aug 12, 2021
@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,134,176 bytes

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 99dce10 into next Aug 12, 2021
@nickdowell nickdowell deleted the nickdowell/test-logging branch August 12, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

@kstenerud kstenerud Awaiting requested review from kstenerud kstenerud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @kattrali