Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-7384] Disable automatic session tracking in app extensions #1211

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Oct 18, 2021

Goal

Disable automatic session tracking in app extensions, because it does not work as intended.

With automatic session tracking enabled, Bugsnag was always reporting a session when started in an app extension (even those that have no user interface) because the UIApplicationState is assumed to be .active - i.e. in [BSG_KSSystemInfo currentAppState]

Changeset

BugsnagSessionTracker now disables automatic tracking if running in an app extension.

Testing

Manually verified that sessions are no longer sent from an app extension.

There are no automated tests covering use in app extensions.

@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,255,032 bytes

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 455b91d into next Oct 18, 2021
@nickdowell nickdowell deleted the nickdowell/disable-auto-sessions-in-extensions branch October 18, 2021 14:54
@nickdowell nickdowell mentioned this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants