Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v6.14.2 #1218

Merged
merged 6 commits into from
Oct 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .jazzy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ author_url: "https://www.bugsnag.com"
author: "Bugsnag Inc"
clean: false # avoid deleting docs/.git
framework_root: "Bugsnag"
github_file_prefix: "https://github.com/bugsnag/bugsnag-cocoa/tree/v6.14.1/Bugsnag"
github_file_prefix: "https://github.com/bugsnag/bugsnag-cocoa/tree/v6.14.2/Bugsnag"
github_url: "https://github.com/bugsnag/bugsnag-cocoa"
hide_documentation_coverage: true
module: "Bugsnag"
module_version: "6.14.1"
module_version: "6.14.2"
objc: true
output: "docs"
readme: "README.md"
Expand Down
4 changes: 2 additions & 2 deletions Bugsnag.podspec.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Bugsnag",
"version": "6.14.1",
"version": "6.14.2",
"summary": "The Bugsnag crash reporting framework for Apple platforms.",
"homepage": "https://bugsnag.com",
"license": "MIT",
Expand All @@ -9,7 +9,7 @@
},
"source": {
"git": "https://github.com/bugsnag/bugsnag-cocoa.git",
"tag": "v6.14.1"
"tag": "v6.14.2"
},
"frameworks": [
"Foundation",
Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Bugsnag+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "Bugsnag.h"
#import <Bugsnag/Bugsnag.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
4 changes: 2 additions & 2 deletions Bugsnag/BugsnagSessionTracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

#import <Foundation/Foundation.h>

#import "BugsnagSession.h"
#import "BugsnagConfiguration.h"
#import <Bugsnag/BugsnagConfiguration.h>
#import <Bugsnag/BugsnagSession.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
3 changes: 3 additions & 0 deletions Bugsnag/BugsnagSessionTracker.m
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ - (BOOL)resumeSession {
} else {
BOOL stopped = session.isStopped;
[session resume];
if (self.callback) {
self.callback(session);
}
[self postUpdateNotice];
return stopped;
}
Expand Down
3 changes: 2 additions & 1 deletion Bugsnag/BugsnagSystemState.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

#import <Foundation/Foundation.h>

#import "BugsnagConfiguration.h"
#import <Bugsnag/BugsnagConfiguration.h>

#import "BugsnagKeys.h"

#define SYSTEMSTATE_KEY_APP @"app"
Expand Down
13 changes: 8 additions & 5 deletions Bugsnag/Client/BugsnagClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,17 @@ - (instancetype)initWithConfiguration:(BugsnagConfiguration *)configuration {
if ((self = [super init])) {
// Take a shallow copy of the configuration
_configuration = [configuration copy];

if (!_configuration.user.id) { // populate with an autogenerated ID if no value set
[_configuration setUser:[BSG_KSSystemInfo deviceAndAppHash] withEmail:_configuration.user.email andName:_configuration.user.name];
}

_state = [[BugsnagMetadata alloc] initWithDictionary:@{
BSGKeyApp: @{BSGKeyIsLaunching: @YES},
BSGKeyClient: BSGDictionaryWithKeyAndObject(BSGKeyContext, _configuration.context)
BSGKeyClient: BSGDictionaryWithKeyAndObject(BSGKeyContext, _configuration.context),
BSGKeyUser: [configuration.user toJson]
}];

_notifier = configuration.notifier ?: [[BugsnagNotifier alloc] init];
self.systemState = [[BugsnagSystemState alloc] initWithConfiguration:configuration];

Expand Down Expand Up @@ -266,10 +273,6 @@ - (instancetype)initWithConfiguration:(BugsnagConfiguration *)configuration {
self.pluginClient = [[BugsnagPluginClient alloc] initWithPlugins:self.configuration.plugins
client:self];

if (self.user.id == nil) { // populate with an autogenerated ID if no value set
[self setUser:[BSG_KSSystemInfo deviceAndAppHash] withEmail:configuration.user.email andName:configuration.user.name];
}

BSGInternalErrorReporter.sharedInstance = [[BSGInternalErrorReporter alloc] initWithDataSource:self];
}
return self;
Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Metadata/BugsnagMetadata+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagMetadata.h"
#import <Bugsnag/BugsnagMetadata.h>

@class BugsnagStateEvent;

Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagApp+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagApp.h"
#import <Bugsnag/BugsnagApp.h>

@class BugsnagConfiguration;

Expand Down
3 changes: 2 additions & 1 deletion Bugsnag/Payload/BugsnagAppWithState+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagAppWithState.h"
#import <Bugsnag/BugsnagAppWithState.h>

#import "BugsnagApp+Private.h"

@class BugsnagConfiguration;
Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagBreadcrumb+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagBreadcrumb.h"
#import <Bugsnag/BugsnagBreadcrumb.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagDevice+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagDevice.h"
#import <Bugsnag/BugsnagDevice.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagDeviceWithState+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagDeviceWithState.h"
#import <Bugsnag/BugsnagDeviceWithState.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
3 changes: 2 additions & 1 deletion Bugsnag/Payload/BugsnagHandledState.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
// Copyright © 2017 Bugsnag. All rights reserved.
//

#import "BugsnagEvent.h"
#import <Foundation/Foundation.h>

#import <Bugsnag/BugsnagEvent.h>

typedef NS_ENUM(NSUInteger, SeverityReasonType) {
UnhandledException,
Signal,
Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagNotifier.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ - (instancetype)init {
#else
_name = @"Bugsnag Objective-C";
#endif
_version = @"6.14.1";
_version = @"6.14.2";
_url = @"https://github.com/bugsnag/bugsnag-cocoa";
_dependencies = @[];
}
Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagSession+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagSession.h"
#import <Bugsnag/BugsnagSession.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
3 changes: 2 additions & 1 deletion Bugsnag/Payload/BugsnagSessionTrackingPayload.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
//

#import <Foundation/Foundation.h>
#import "BugsnagSession.h"

#import <Bugsnag/BugsnagSession.h>

@class BugsnagConfiguration;
@class BugsnagNotifier;
Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Payload/BugsnagUser+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2020 Bugsnag Inc. All rights reserved.
//

#import "BugsnagUser.h"
#import <Bugsnag/BugsnagUser.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 1 addition & 1 deletion Bugsnag/Plugins/BugsnagPluginClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#import <Foundation/Foundation.h>

#import "BugsnagPlugin.h"
#import <Bugsnag/BugsnagPlugin.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
3 changes: 2 additions & 1 deletion Bugsnag/Storage/BugsnagSessionFileStore.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

#import <Foundation/Foundation.h>

#import <Bugsnag/BugsnagSession.h>

#import "BugsnagFileStore.h"
#import "BugsnagSession.h"

@interface BugsnagSessionFileStore : BugsnagFileStore
+ (BugsnagSessionFileStore *)storeWithPath:(NSString *)path
Expand Down
6 changes: 3 additions & 3 deletions BugsnagNetworkRequestPlugin.podspec.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"name": "BugsnagNetworkRequestPlugin",
"version": "6.14.1",
"version": "6.14.2",
"summary": "Network request monitoring support for Bugsnag.",
"homepage": "https://bugsnag.com",
"license": "MIT",
"authors": {
"Bugsnag": "[email protected]"
},
"readme": "https://raw.githubusercontent.com/bugsnag/bugsnag-cocoa/v6.14.1/BugsnagNetworkRequestPlugin/README.md",
"readme": "https://raw.githubusercontent.com/bugsnag/bugsnag-cocoa/v6.14.2/BugsnagNetworkRequestPlugin/README.md",
"source": {
"git": "https://github.com/bugsnag/bugsnag-cocoa.git",
"tag": "v6.14.1"
"tag": "v6.14.2"
},
"dependencies": {
"Bugsnag": "~> 6.13"
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
Changelog
=========

## 6.14.2 (2021-10-27)

### Bug fixes

* Fix missing `configuration.user` and manually resumed `session` info in unhandled errors.
[#1215](https://github.com/bugsnag/bugsnag-cocoa/pull/1215)

## 6.14.1 (2021-10-20)

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion Framework/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>6.14.1</string>
<string>6.14.2</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
Expand Down
2 changes: 1 addition & 1 deletion Tests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
<key>CFBundleShortVersionString</key>
<string>6.14.1</string>
<string>6.14.2</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.14.1
6.14.2
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,16 @@ class BareboneTestUnhandledErrorScenario: Scenario {
}
} else {
// The version of the app at crash time.
config.addMetadata(["group": "users"], section: "user")
config.appVersion = "12.3"
config.bundleVersion = "12301"
config.context = "Something"
config.setUser("barfoo", withEmail: "[email protected]", andName: "Bar Foo")
}
super.startBugsnag()
}

override func run() {
Bugsnag.setContext("Something")
Bugsnag.setUser("barfoo", withEmail: "[email protected]", andName: "Bar Foo")
Bugsnag.addMetadata(["group": "users"], section: "user")

// Triggers "Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value: ..."
print(payload.name)
}
Expand Down