-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visionOS support #1565
base: master
Are you sure you want to change the base?
Fix visionOS support #1565
Conversation
See below comment from @marcpalmer and my subsequent update. |
I think this could land pre-Xcode 15 release with a check for the definition of the macro? Wouldn't something like this work:
If this does not ship until after Xcode 15 is GM nobody can use bugsnag in the interim without forking, and even after Xcode 15 is GM, many people will still be using Xcode 14 so we need a fix that works for any Xcode release? |
@marcpalmer that's a good point. My objc is fairly rusty so thanks for the direction. Added that here. |
HI @msmollin @marcpalmer , Thanks for this PR, adding official support for VisionOS is definitely something we are interested in doing, however do need to do some additional work to fully understand the scope of changes involved. Going to leave this open for now and we will revisit soon. Sounds like forking the repo is the most reasonable workaround for now. |
With Xcode 15.2 now officially (no longer a beta) released with visionOS support, should this be revisited? Sentry also has a PR up that adds visionOS support. |
Hi @matthargett |
Goal
This fixes a build error when targeting visionOS (xrOS) devices in Xcode 15 beta 2
Design
Per the docs listed here:
https://developer.apple.com/documentation/visionos/bringing-your-app-to-visionos#Isolate-features-that-are-unavailable-in-visionOS
Changeset
Added a
!TARGET_OS_XR
condition on the front per recommendations from Apple docs.Testing
Imported my fork into my project and it built whereas it did not before.