-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Maze Runner v8 #1566
Merged
Merged
Update to Maze Runner v8 #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
twometresteve
force-pushed
the
tms/maze-v8
branch
from
June 28, 2023 17:14
56dbb85
to
6175779
Compare
tomlongridge
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Upgrade e2e tests to Maze Runner v8.
Design
Whilst preparing this change, BrowserStack removed support for Appium 1.8.0. I've worked round that by changing the test fixture to poll for Maze commands rather than react to button presses (which cause instability on iOS 10/11 with the version of Appium that we now have access to). I've refactored the code for polling for commands into a new
Thread
class.Changeset
Scenarios also updated in line with the Maze Runner upgrade guide.
Testing
Covered by a full CI run.