-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run e2e tests against XcFramework test fixture #1684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
twometresteve
force-pushed
the
tms/framework-fixture-2
branch
from
July 29, 2024 15:43
eca44d4
to
cc302b0
Compare
kstenerud
approved these changes
Jul 30, 2024
[full ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Run e2e tests against a test fixture built with the BugSnag XcFramework.
Design
The test fixture for iOS was duplicated and modified to include the XcFramework for the notifier. A subset of tests will be run against this, on the earliest and latest iOS versions, for a full build.
Changeset
While preparing this change I checked that the whole set of e2e tests pass against the fixture, so there are some changes to tests that won't actually be run as part of the cut-down set.
Testing
Covered by a full CI run.