Create date formatters at initialization time rather than at runtime #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some null pointer exceptions in code that was using BSG_RFC3339DateTool, which seems to be caused by a nil instance of the date formatter. I couldn't find any definitive culprit, but with this change there's zero possibility of the formatter ever being nil again.
kstenerud
force-pushed
the
5047-date-tool
branch
from
7c10100
to
6c22595
Compare
kattrali
approved these changes
Sep 16, 2020
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some null pointer exceptions in code that was using BSG_RFC3339DateTool, which seems to be caused by a nil instance of the date formatter. I couldn't find any definitive culprit, but with this change there's zero possibility of the formatter ever being nil again.
Crash: -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[2]
Crashing code: https://github.com/bugsnag/bugsnag-cocoa/blob/v6.1.2/Bugsnag/Delivery/BugsnagSessionTrackingApiClient.m#L74
Potentially problematic code: https://github.com/bugsnag/bugsnag-cocoa/blob/v6.1.2/Bugsnag/Helpers/BSG_RFC3339DateTool.m#L36
Fixes https://bugsnag.atlassian.net/browse/PLAT-5047