[PLAT-5000] React Native promise rejection stack trace processing #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
suggested changes
Sep 21, 2020
kattrali
approved these changes
Sep 21, 2020
nickdowell
deleted the
5000-react-native-promise-rejection-stacktrace-processing
branch
JoeLago
reviewed
Mar 16, 2021
| + (NSArray<BugsnagStackframe *> *)stackframesWithCallStackSymbols:(NSArray<NSString *> *)callStackSymbols { | ||
| NSString *pattern = (@"^(\\d+)" // Capture the leading frame number | ||
| @" +" // Skip whitespace | ||
| @"(\\S+)" // Image name |
There was a problem hiding this comment.
Hi, sorry if it's inappropriate to dig up an old pull request like this. I was trying to use this function to rebuild a stacktrace with some callStackSymbols I cached for a handled error and I believe I'm losing my apps frames because there is a space in our apps display name. For Example:
"0 ReactNative Test 0x000000010fda7f1b RCTJSErrorFromCodeMessageAndNSError + 79"
There was a problem hiding this comment.
Thanks for reporting this - we are working on a fix: #1036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This change allows BugsnagReactNative to convert the native promise rejection stack trace provided by React Native into an array of BugsnagStackframe objects, so that it can be captured as a BugsnagError.
Design
See ROAD-801 for details of the design and specification.
Changeset
[BugsnagStackframe stackframesWithCallStackSymbols:]was added, which will be invoked by BugsnagReactNative.Testing
Unit test cases have been added to verify the processing of passed in call stacks into BugsnagStackframe objects.
End-to-end automated tests will be covered in bugsnag-js