Timestamps are now represented to the millisecond rather than the second #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5191-timestamp-precision
branch
from
27f2ec4
to
4109a98
Compare
kstenerud
force-pushed
the
5191-timestamp-precision
branch
from
4109a98
to
cbc7f49
Compare
nickdowell
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Timestamp precision is currently only to the second. For some calculations, we really need millisecond precision. This is in particular important for breadcrumbs so that their order can be distinguished more easily.
Design
The time formatter was changed to write to the millisecond, and to read first to the millisecond, and then progressively attempt to read the legacy formats.
Changeset
BSG_RFC3339DateTool.mhas been updated to handle milliseconds.Testing