[PLAT-5682] Make max persisted events/sessions spec compliant #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Make
maxPersistedEventsandmaxPersistedSessionsmore closely follow the specificationChangeset
Adjusted the implementation and documentation to closely follow the specification and Android implementation.
Removed the custom getters - these are no longer required since the properties are now
nonatomic.Adjusted the unit tests.
Note when using
XCTAssertmacros that the expected value should be passed as the second argument, as demonstrated in Apple's documentation. Many of our existing tests do not follow this convention, but new code should.Testing
Manually ran the unit tests.