[PLAT-5789] Fix property declaration warnings

[nickdowell]

Goal

The public headers were triggering compiler warnings when imported by a compilation unit with ARC disabled.

Furthermore many of the string properties were not declared as copy potentially leading to being passed mutable values that could subsequently be changed.

Design

Following the raywenderlich.com Objective-C style guide for the property declarations;

Property attributes should be explicitly listed, and will help new programmers when reading the code. The order of properties should be storage then atomicity, which is consistent with automatically generated code when connecting UI elements from Interface Builder.

Preferred:

@property (weak, nonatomic) IBOutlet UIView *containerView;
@property (strong, nonatomic) NSString *tutorialName;

Not Preferred:

@property (nonatomic, weak) IBOutlet UIView *containerView;
@property (nonatomic) NSString *tutorialName;

Properties with mutable counterparts (e.g. NSString) should prefer copy instead of strong.
Why? Even if you declared a property as NSString somebody might pass in an instance of an NSMutableString and then change it without you noticing that.

Preferred:

@property (copy, nonatomic) NSString *tutorialName;

Not Preferred:

@property (strong, nonatomic) NSString *tutorialName;

Changeset

• Adds an empty .m file that is compiled without ARC to expose all the warnings
• Fixes all the warnings
• Properties with mutable counterparts (e.g. NSString) now use copy
• Most properties are nonatomic because they will not be written and read by different threads.

Testing

Tested warnings with Xcode 12.3

[github-actions]

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,060,360 bytes

Generated by 🚫 Danger