Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support monorepo #147

Open
wants to merge 1 commit into
base: v49/next
Choose a base branch
from

Conversation

ricardoribas
Copy link

@ricardoribas ricardoribas commented Aug 30, 2023

Goal

When we setup bugsnag react native package, it doesn't support 100% monorepo. Apparently, the best option right now to support it is to perform hoisting on packages (if you are using yarn workspaces). The idea is to support a standalone package, but also monorepo.

Design

To better locate the bugsnag sourcemap package. When executing under the xcode build phases, the relative path will not work if we are working under monorepo projects. With this approach, the problem gets solved.

Changeset

  1. Created xcode build phase script to add the node_binary to the execution context.
  2. Changed the ios plugin to include the new build phase script
  3. Changed bash script to execute the bugsnag source maps binary regardless of the package location

Also refers to the bugsnag/source-maps package PR87

Testing

Right now i just tested on my project. I would need some guidance in order to test it properly and not affect other developers. Feedback is needed 😄

…ion context

Changed the ios plugin to include the new build phase script
Changed bash script to execute the bugsnag source maps binary regardless of the package location
@clr182 clr182 added the needs discussion Requires internal analysis/discussion label Sep 11, 2023
@clr182 clr182 added feature request Request for a new feature backlog We hope to fix this feature/bug in the future and removed needs discussion Requires internal analysis/discussion labels Sep 21, 2023
@clr182
Copy link

clr182 commented Sep 21, 2023

Hi @ricardoribas
Thank you for opening this pull request, I've added it to our backlog and like for your PR on our source-maps repo, one of our engineers will take a look when priorities allow.

@ricardoribas
Copy link
Author

@clr182 do you have any update on this?

@mclack
Copy link

mclack commented Jan 2, 2024

Hi @ricardoribas

We appreciate your patience here.

Unfortunately we don't have any updates on an ETA yet, but this remains on our backlog to be looked at when priorities allow.

We will make sure to post any updates here when they are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants