Skip to content

Commit

Permalink
Merge pull request #781 from bugsnag/expo-sdk-37-support
Browse files Browse the repository at this point in the history
Expo SDK 37 support
  • Loading branch information
bengourley authored Apr 2, 2020
2 parents e8adfd7 + 958990c commit e1e7758
Show file tree
Hide file tree
Showing 11 changed files with 9,837 additions and 4,664 deletions.
4 changes: 2 additions & 2 deletions dockerfiles/Dockerfile.expo-android-builder
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list

RUN apt-get update
RUN apt-get install -y nodejs make g++ yarn rsync
RUN apt-get install -y nodejs make g++ yarn rsync jq

WORKDIR /app/test/expo/features/fixtures/test-app

RUN mkdir -p /app/test/expo/features/fixures/build

RUN yarn global add gulp-cli node-gyp
RUN yarn add bunyan rsync turtle-cli@0.13.1
RUN yarn add bunyan rsync turtle-cli@0.14

RUN node_modules/.bin/turtle setup:android

Expand Down
6 changes: 3 additions & 3 deletions packages/delivery-expo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/delivery-expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"license": "MIT",
"dependencies": {
"@bugsnag/core": "^6.5.0",
"@react-native-community/netinfo": "4.6.0",
"@react-native-community/netinfo": "5.5.0",
"expo-file-system": "^6.0.2"
},
"devDependencies": {
Expand Down
4 changes: 4 additions & 0 deletions packages/expo-cli/commands/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,17 @@ const selectVersion = async (dir) => {
// help select compatible versions of @bugsnag/expo for older expo releases
const isPre33 = (expoVersion && !semver.gte(semver.minVersion(expoVersion), '33.0.0'))
const isPre36 = (expoVersion && !semver.gte(semver.minVersion(expoVersion), '36.0.0'))
const isPre37 = (expoVersion && !semver.gte(semver.minVersion(expoVersion), '37.0.0'))

if (isPre33) {
message = 'It looks like you’re using a version of Expo SDK <33. The last version of Bugsnag that supported your version of Expo is v6.3.0'
defaultVersion = '6.3.0'
} else if (isPre36) {
message = 'It looks like you’re using a version of Expo SDK <36. The last version of Bugsnag that supported your version of Expo is v6.4.1'
defaultVersion = '6.4.1'
} else if (isPre37) {
message = 'It looks like you’re using a version of Expo SDK <37. The last version of Bugsnag that supported your version of Expo is v6.5.1'
defaultVersion = '6.5.1'
}

const { version } = await prompts({
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"author": "Bugsnag",
"license": "MIT",
"dependencies": {
"@react-native-community/netinfo": "4.6.0"
"@react-native-community/netinfo": "5.5.0"
},
"devDependencies": {
"@bugsnag/core": "^6.5.0",
Expand Down
2 changes: 1 addition & 1 deletion test/expo/features/fixtures/test-app/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Test Fixture",
"slug": "test-fixture",
"privacy": "unlisted",
"sdkVersion": "36.0.0",
"sdkVersion": "37.0.0",
"platforms": [
"ios",
"android"
Expand Down
Loading

0 comments on commit e1e7758

Please sign in to comment.