Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing clientIp and referer in request object #615

Closed
aroslov opened this issue Aug 21, 2019 · 2 comments · Fixed by #617
Closed

Missing clientIp and referer in request object #615

aroslov opened this issue Aug 21, 2019 · 2 comments · Fixed by #617
Labels
bug Confirmed bug released This feature/bug fix has been released

Comments

@aroslov
Copy link

aroslov commented Aug 21, 2019

Compare code at

const requestInfo = extractRequestInfo(ctx)

and

module.exports = ctx => {

First function expects requestInfo.clientIp and requestInfo.referer attributes, but second function doesn't provide it. Looks like a bug.

@abigailbramble abigailbramble added the bug Confirmed bug label Aug 22, 2019
@abigailbramble
Copy link

@aroslov Thank you for your comments. We will look into this.

@abigailbramble abigailbramble added the backlog We hope to fix this feature/bug in the future label Aug 22, 2019
@abigailbramble abigailbramble added scheduled Work is starting on this feature/bug and removed backlog We hope to fix this feature/bug in the future labels Sep 2, 2019
bengourley added a commit that referenced this issue Sep 5, 2019
bengourley added a commit that referenced this issue Sep 5, 2019
@mattdyoung
Copy link
Contributor

This was fixed in v6.4.1.

@mattdyoung mattdyoung added released This feature/bug fix has been released and removed scheduled Work is starting on this feature/bug labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug released This feature/bug fix has been released
Projects
None yet
3 participants