Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "use strict;" to library #90

Closed
arturnt opened this issue Nov 7, 2014 · 6 comments
Closed

Add "use strict;" to library #90

arturnt opened this issue Nov 7, 2014 · 6 comments

Comments

@arturnt
Copy link

arturnt commented Nov 7, 2014

We use a Google Closure compiler with EC5 strict mode. The library breaks at it's use of arguments.callee.

@ConradIrwin
Copy link

Unfortunately arguments.callee is the only way to get stack-traces on old versions of IE (< 10) :/.

It might be possible for us to compile a strict-mode compatible version of bugsnag.js; but if it's possible to exempt some files from the Closure compilers strict check, then that would be an easier solution.

@ConradIrwin
Copy link

(obviously, a strict mode compatible version would be incompatible with old IE, but that's a trade-off I think some people would be happy with).

@arturnt
Copy link
Author

arturnt commented Nov 7, 2014

Is it possible to cut two versions (jQuery style)?

@ConradIrwin
Copy link

Almost certainly :). Can you tell me the easiest way to check a file against the Closure compiler's strict mode for testing?

@ConradIrwin
Copy link

Obviously for now, you're welcome to just delete the offending code in your fork (assuming you don't care about old IE).

@ConradIrwin
Copy link

Going to close this for now as it won't happen until we revisit how the library is built to support variants.

kattrali pushed a commit that referenced this issue Apr 22, 2021
Fix 'user' not being set in renderer Events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants