-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "use strict;" to library #90
Comments
Unfortunately It might be possible for us to compile a strict-mode compatible version of bugsnag.js; but if it's possible to exempt some files from the Closure compilers strict check, then that would be an easier solution. |
(obviously, a strict mode compatible version would be incompatible with old IE, but that's a trade-off I think some people would be happy with). |
Is it possible to cut two versions (jQuery style)? |
Almost certainly :). Can you tell me the easiest way to check a file against the Closure compiler's strict mode for testing? |
Obviously for now, you're welcome to just delete the offending code in your fork (assuming you don't care about old IE). |
Going to close this for now as it won't happen until we revisit how the library is built to support variants. |
Fix 'user' not being set in renderer Events
We use a Google Closure compiler with EC5 strict mode. The library breaks at it's use of arguments.callee.
The text was updated successfully, but these errors were encountered: