Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-4848] RN: Add type definitions to published package files #1002

Merged
merged 2 commits into from
Aug 17, 2020
Merged

[PLAT-4848] RN: Add type definitions to published package files #1002

merged 2 commits into from
Aug 17, 2020

Conversation

bengourley
Copy link
Contributor

The type definitions were not inlude in the files list in the React Native package's manifest.

@bengourley bengourley changed the title fix(react-native) Add type definitions to published package files [PLAT-4848] RN: Add type definitions to published package files Aug 17, 2020
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 17, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 99ab64a

djskinner
djskinner approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@djskinner djskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reproduced original error on importing @bugsnag/react-native with a RN TypeScript app. Bumped to v7.3.2-alpha.0 and the error disappears and types are available.

@bengourley bengourley merged commit 85f8b09 into next Aug 17, 2020
@bengourley bengourley deleted the bengourley/react-native-types-in-package branch August 17, 2020 15:48
@bengourley bengourley mentioned this pull request Aug 17, 2020
Merged
@henrymoulton
Copy link

Thanks guys for the speedy fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bengourley @bugsnagbot @henrymoulton @djskinner