Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress unchecked cast warnings for React Native Android #1027

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Suppresses an unchecked cast warning observed when building an example app which includes @bugsnag/react-native as a dependency. This cast is required to read the data in an agreed format but can be suppressed so that they don't show for end-users.

Testing

Ran the local example app and confirmed that npx react-native run-android did not show compiler warnings.

@fractalwrench fractalwrench requested a review from a team as a code owner September 1, 2020 14:35
@fractalwrench fractalwrench changed the title Suppress unchecked cast warnings for RN Android Suppress unchecked cast warnings for React Native Android Sep 1, 2020
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Sep 1, 2020

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 8332754

@fractalwrench fractalwrench merged commit 00f9fc4 into next Sep 4, 2020
@fractalwrench fractalwrench deleted the PLAT-4923/suppress-warnings branch September 4, 2020 08:37
@bengourley bengourley mentioned this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants