Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-4921] Fix @bugsnag/react-native proguard compatibility #1030

Merged
merged 5 commits into from
Sep 3, 2020
Merged

[PLAT-4921] Fix @bugsnag/react-native proguard compatibility #1030

merged 5 commits into from
Sep 3, 2020

Conversation

bengourley
Copy link
Contributor

@bengourley bengourley commented Sep 2, 2020 •
edited
Loading

Addresses #998.

  • Updates the vendored bugsnag-android to include this fix.
  • Modifies the tests to use proguard on the application so that CI would catch any future regressions in this area
  • Removes the duplicate proguard rules from this repo – they are inculded in bugsnag-android/bugsnag-plugin-react-native.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Sep 2, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against f824321

@bengourley bengourley marked this pull request as ready for review September 3, 2020 14:37
@bengourley bengourley requested a review from a team as a code owner September 3, 2020 14:37
fractalwrench
fractalwrench approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

twometresteve
twometresteve reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a test perspective.

@bengourley bengourley merged commit eaa6115 into next Sep 3, 2020
@bengourley bengourley deleted the bengourley/rn-proguard-fix branch September 3, 2020 16:19
@bengourley bengourley mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve left review comments

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bengourley @bugsnagbot @twometresteve @fractalwrench