Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bugsnag-android to v5.2.1 #1080

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Update bugsnag-android to v5.2.1 #1080

merged 1 commit into from
Oct 1, 2020

Conversation

imjoehaines
Copy link
Contributor

@imjoehaines imjoehaines commented Oct 1, 2020 •
edited
Loading

Goal

Update vendored bugsnag-android from v5.1.0 to v5.2.1

Changeset

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Oct 1, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.57 kB 12.52 kB
After 40.57 kB 12.52 kB
± No change No change

Generated by 🚫 dangerJS against fe008c6

@imjoehaines imjoehaines marked this pull request as ready for review October 1, 2020 09:50
@imjoehaines imjoehaines requested a review from a team as a code owner October 1, 2020 09:50
bengourley
bengourley suggested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions on these lines needs updating too

bugsnag-js/packages/react-native/android/build.gradle

Lines 43 to 44 in 9b0971a

api "com.bugsnag:bugsnag-android:5.1.0-react-native"
api "com.bugsnag:bugsnag-plugin-react-native:5.1.0-react-native"

(there is a ticket to automate this but we should probably update the release guide until we get to that)

packages/react-native/update-android.sh Outdated Show resolved Hide resolved
@imjoehaines imjoehaines closed this Oct 1, 2020
@imjoehaines imjoehaines reopened this Oct 1, 2020
@imjoehaines imjoehaines merged commit eaafaaf into next Oct 1, 2020
@imjoehaines imjoehaines deleted the update-android-5.2.1 branch October 1, 2020 12:27
@imjoehaines imjoehaines mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imjoehaines @bugsnagbot @bengourley