Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-4932] feat(react-native-cli): Add install command #1141

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

bengourley
Copy link
Contributor

@bengourley bengourley commented Nov 24, 2020

Adds bugsnag-react-native-cli install command.

Unit tests included for relevant parts. Interactive CLI aspects will be test via maze runner at a later point.

To test this out, use the following steps:

  • git fetch && git checkout feature/rn-cli-install-cmd
  • npm i
  • npm run bootstrap
  • npm run build
  • cd packages/react-native-cli
  • npm link (this symlinks the local cli package to your global npm modules)

On a React Native project:

  • check that the command is linked up correctly bugsnag-react-native-cli --help
  • run bugsnag-react-native-cli install
  • verify that Bugsnag is installed (note that it will be integrated in another command insert so won't actually do anything until then)

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 24, 2020

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.57 kB 12.52 kB
After 40.57 kB 12.52 kB
± No change No change

Generated by 🚫 dangerJS against 64e7c04

@bengourley bengourley merged commit 23e96aa into integration/rn-cli Nov 26, 2020
@bengourley bengourley deleted the feature/rn-cli-install-cmd branch November 26, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants