[PLAT-4934] Add configure command to RN CLI #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
approved these changes
Nov 25, 2020
| name: 'apiKey', | ||
| message: 'What is your Bugsnag API key?', | ||
| validate: value => { | ||
| return value.length > 1 |
There was a problem hiding this comment.
Is there value in validating that the apiKey is a hexadecimal string of the correct length?
Base automatically changed from
feature/rn-cli-install-cmd
to
integration/rn-cli
November 26, 2020 10:18
bengourley
changed the title
bengourley
changed the title
nickdowell
reviewed
Nov 27, 2020
| logger.warn(UNLOCATED_PROJ_MSG) | ||
| return | ||
| } | ||
| const plistPath = path.join(iosDir, xcodeprojDir.replace(/\.xcodeproj$/, ''), 'Info.plist') |
There was a problem hiding this comment.
This works fine with react native's project template but may break if developers reorganise their project structure. Determining the path 100% correctly would involve parsing the Xcode project and finding the INFOPLIST_FILE build setting for the app target... tricky to implement, so this current solution is probably good enough!
nickdowell
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
bugsnag-react-native-cli installcommand.Unit tests included for relevant parts. Interactive CLI aspects will be test via maze runner at a later point.
To test this out, use the following steps:
git fetch && git checkout feature/rn-cli-configure-cmdnpm inpm run bootstrapnpm run buildcd packages/react-native-clinpm link(this symlinks the local cli package to your global npm modules)On a React Native project:
bugsnag-react-native-cli --helpbugsnag-react-native-cli configure