Bump to Cocoa library to 6.4.1 #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
cocoa-6.4.1
branch
from
873aed6
to
ff106c0
Compare
kstenerud
commented
Dec 14, 2020
| return [[BugsnagHandledState alloc] initWithSeverityReason:reason | ||
| severity:severity | ||
| unhandled:unhandled | ||
| unhandledOverridden:unhandledOverridden |
There was a problem hiding this comment.
Changes to cocoa internal API required these fixes RN-side (BugsnagEventDeserializer).
bengourley
approved these changes
Dec 14, 2020
| @@ -156,9 +157,11 @@ - (BugsnagHandledState *)deserializeHandledState:(NSDictionary *)payload { | |||
|
|
|||
| BSGSeverity severity = BSGParseSeverity(payload[@"severity"]); | |||
| BOOL unhandled = [payload[@"unhandled"] boolValue]; | |||
| BOOL unhandledOverridden = [severityReason[@"unhandledOverridden"] boolValue]; | |||
There was a problem hiding this comment.
what is the behaviour of this when
a. severityReason is nil?
b. severityReason.unhandledOverridden doesn't exist, or isn't a boolean?
There was a problem hiding this comment.
Messages to nil objects in ObjC return 0, which is converted to nil, and then the subcall (also to a nil object) is converted to boolean false in this case.
If unhandledOverridden is a string, number, boolean, or nil, it will return Objective-C's interpretation of that type as a boolean value. If it's any other type, it will throw an exception.
fractalwrench
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: