Avoid starting a session if one already exists #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 40.83 kB |
12.60 kB |
| After | 40.84 kB |
12.60 kB |
| ± | +13 bytes |
+5 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-browser-session/session.js | 95.24% (-4.76%) |
87.5% (-12.5%) |
100% (+0%) |
95.24% (-4.76%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-server-session/session.js | 75% (-1.09%) |
50% (+0%) |
66.67% (+0%) |
71.15% (-0.85%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 81.47%(-0.04%) | 70.32%(-0.05%) | 84.01%(+0%) | 80.38%(-0.04%) |
bengourley
approved these changes
Mar 8, 2021
This change prevents multiple sessions from being started if separate plugins both call 'startSession' by making 'resumeSession' do nothing if a session already exists
imjoehaines
force-pushed
the
avoid-double-sessions
branch
from
bb14fad
to
441a361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This change prevents multiple sessions from being started if separate plugins both call 'startSession' by making 'resumeSession' do nothing if a session already exists
This is necessary in order to run serverless versions of Express/Koa/Restify with
autoTrackSessionson because both the AWS Lambda plugin and the framework plugin will attempt to start a session (resulting in 2 sessions per request)