Add AWS Lambda tests to CI #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI doesn't have an up-to-date bundler version, but it's not really worth updating as we have a single pinned dependency (so it's essentially locked even without a lockfile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the AWS Lambda tests to CI. This was failing to install the top-level dependencies because NPM resolved the dependencies differently to Artifactory (which is the default on CI) — I'm not sure why this happens though!
NPM has resolved both
@babel/helper-define-mapand@babel/helper-explode-assignable-expressionto the same package (@babel/helper-define-map). When Artifactory is used as the registry, it doesn't do this so the checksums don't match — because it's downloaded them as two different packagesThis is weird but doesn't seem to break anything and NPM does the exact same thing if you recreate the lockfile so I don't think it's a bug per-se. To fix it, we can tell NPM to use its registry instead of Artifactory when installing the top-level dependencies
The CI boxes also have an older version of Bundler which refused to install from our Gemfile.lock — we don't really need the lockfile because we pin our single dependency (MazeRunner) to a specific tag, so I opted to delete the lockfile instead of changing the CI environment
The 35 minute timeout is ~10 minutes longer than it currently takes to run, so it has a bit of room