Electron: Ensure stripping project root works on paths with spaces #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In a renderer stacktrace, paths are URI encoded (so for example a space is the literal
%20). The goal of this PR is to fix a bug where the stacktrace (and also the context) showed with a the full, absolute path, rather than the relative path from the project root.Design
decodeURIfits this exact use caseChangeset
Once
stackframe.fileis confirmed to be a string, pass it throughdecodeURIbefore any subsequent processing.Testing
Tested manually on my mac. Unit tests added.