Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron: Misc CI improvements #1372

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Electron: Misc CI improvements #1372

merged 2 commits into from
Apr 29, 2021

Conversation

bengourley
Copy link
Contributor

  • Increase the threshold for startup latency – the justification is that CI machines can be a lot slower or congested than normal devices.
  • Rename the Github Actions workflow so that it is more obvious what it is for when looking at the status checks panel

@bengourley bengourley force-pushed the bengourley/electron-ci-improvements branch from 956e9b6 to 0ecec21 Compare April 28, 2021 14:42
@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.87 kB 12.62 kB
After 40.87 kB 12.62 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 0ecec21

@bengourley bengourley merged commit 1e2a6b3 into kattrali/add-electron-support Apr 29, 2021
@bengourley bengourley deleted the bengourley/electron-ci-improvements branch April 29, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoehaines imjoehaines imjoehaines approved these changes

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengourley @imjoehaines