Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RN CLI tests for RN 0.64 (non-Hermes) #1448

Merged
merged 16 commits into from
Jun 29, 2021
Merged

Add RN CLI tests for RN 0.64 (non-Hermes) #1448

merged 16 commits into from
Jun 29, 2021

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Jun 28, 2021

Goal

Adds tests to the RN CLI CI pipeline for RN 0.64 (non-Hermes).

Design

Follows the existing approach for previous version of React Native.

Changeset

  • New test fixture for RN 0.64.
  • Required adjustments to inited test fixture app now detailed in TESTING.md
  • Build steps added to pipeline

The overall changeset is probably quite hard to review due to all the new test fixture files. Individual commits should be fairly straightforward to scan through.

Testing

Covered by CI.

@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.18 kB 12.67 kB
After 41.18 kB 12.67 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 872519f

@twometresteve twometresteve merged commit 097075c into next Jun 29, 2021
@twometresteve twometresteve deleted the tms/rn-cli-64 branch June 29, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants