[PLAT-5052] feat(plugin-browser-device): Use device id as default user id #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.19 kB |
12.68 kB |
| After | 41.32 kB |
12.70 kB |
| ± | +128 bytes |
+29 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-browser-device/device.js | 100% (+0%) |
96.55% (+1.31%) |
100% (+0%) |
100% (+0%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.38%(+0.02%) | 71.91%(+0.11%) | 83.47%(+0.02%) | 81.43%(+0.03%) |
imjoehaines
approved these changes
Jul 1, 2021
|
This broke the "setting collectUserIp option to false" MR test because it now gets the device ID |
bengourley
force-pushed
the
bengourley/browser-device-id-default-user-id
branch
from
fa41d1f
to
4612d4a
Compare
bengourley
force-pushed
the
bengourley/browser-device-id-default-user-id
branch
from
4612d4a
to
8bc5a2c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1454 but for browser JS.
This time it is gated by the
collectUserIpconfig option.