[PLAT-8735] Preserve feature flag order #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
changed the title
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 42.67 kB |
13.08 kB |
| After | 43.13 kB |
13.19 kB |
| ± | +460 bytes |
+115 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/client.js | 99.39% (+0.01%) |
97.65% (+0%) |
100% (+0%) |
98.87% (+0.01%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/core/event.js | 96.03% (+0.06%) |
93.15% (+0%) |
100% (+0%) |
96.3% (+0.06%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-ipc/bugsnag-ipc-main.js | 83.08% (+0.27%) |
73.08% (+0%) |
89.47% (+0%) |
81.94% (+0.25%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-renderer-event-data/renderer-event-data.js | 90.48% (+0.48%) |
81.25% (+0%) |
100% (+0%) |
91.3% (+0.39%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 87.27%(+0.05%) | 75.52%(+0.05%) | 86.76%(+0%) | 86.2%(+0.05%) |
gingerbenw
force-pushed
the
PLAT-8735-preserve-feature-flag-order
branch
from
c1bc6bd
to
68bd1c3
Compare
gingerbenw
force-pushed
the
PLAT-8735-preserve-feature-flag-order
branch
from
68bd1c3
to
eabc08c
Compare
nickdowell
reviewed
Aug 18, 2022
| for (var i = 0; i < existingFeatures.length; i++) { | ||
| if (existingFeatures[i].name === name) { | ||
| found = true | ||
| existingFeatures[i].variant = variant |
There was a problem hiding this comment.
Would it be safer to replace rather than mutate the object, since an event.features may also contain it?
e.g.
Suggested change
| existingFeatures[i].variant = variant | |
| existingFeatures[i].variant = { name, variant } |
There was a problem hiding this comment.
I don't think it makes any difference here, as the flag will have been cloned from the event, rather than referenced.
djskinner
reviewed
Aug 19, 2022
djskinner
reviewed
Aug 19, 2022
gingerbenw
force-pushed
the
PLAT-8735-preserve-feature-flag-order
branch
from
555f060
to
62a27df
Compare
gareththackeray
approved these changes
Aug 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To preserve the order of feature flags as they were added
Design
Changed internal feature storage from an object to an array, added relevant poly fills for IE11 compatibility
Testing
Unit and integration tests updated