Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update browser delivery tests to respond with a log, add delivery tests to node #1866

Merged
merged 22 commits into from
Nov 28, 2022
Merged

Update browser delivery tests to respond with a log, add delivery tests to node #1866

merged 22 commits into from
Nov 28, 2022

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 9, 2022 •
edited
Loading

Goal

This updates the delivery browser tests to:

  • Wait for several seconds to ensure the delivery process is not repeated
  • Expect a log back from the page showing receipt of the rejection
    This is currently very flakey on IE10, hence this test being skipped for the time being and a separate ticket will be created for it.

EDIT - Now implements the changes for node as well

@github-actions
Copy link

github-actions bot commented Nov 9, 2022 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.43 kB 13.34 kB
After 43.43 kB 13.34 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 7e88ff0

@Cawllec Cawllec changed the title Update browser delivery tests to respond with a log Update browser delivery tests to respond with a log, add delivery tests to node Nov 24, 2022
djskinner
djskinner approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@djskinner djskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'm going to fold this into my PR and assess next steps

@djskinner djskinner merged commit f445c2f into plat-8731 Nov 28, 2022
@djskinner djskinner deleted the plat-8731-testing branch November 28, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cawllec @djskinner