Add unit tests for clone-client #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
commented
Dec 2, 2022
| @@ -50,7 +50,8 @@ export default class ClientWithInternals<T extends Config = Config> extends Clie | |||
| _user: User | |||
|
|
|||
| _metadata: { [key: string]: any } | |||
| _features: FeatureFlag | null[] | |||
| _features: Array<FeatureFlag | null> | |||
| _featuresIndex: { [key: string]: number } | |||
There was a problem hiding this comment.
_featuresIndex needed adding here to get the unit test to compile
The previous '_features' type definition means 'a FeatureFlag or an array of nulls', but should be 'an array of FeatureFlags and/or nulls'
imjoehaines
force-pushed
the
clone-client-unit-tests
branch
from
6d1f9b6
to
5e3494a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Added some unit tests for clone-client in preparation for some upcoming changes
In practice a lot of this is already covered by other tests that use clone-client, but hopefully these will allow easier debugging if something does break