Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RN pipeline to use Maze Runner v7 #1886

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Conversation

twometresteve
Copy link
Contributor

Goal

Update RN pipeline to use Maze Runner v7.

Design

This was a fairly standard upgrade to v7, following the path already walked by the likes of bugsnag-android.

I did find, however, that at least one of the test scenarios (Unhandled native error) became flaky when moving to the new terminate_app/terminate_app Appium driver calls. This will need further investigation, so for now I have just stuck with the "old" close_app and launch_app calls (they seem to work absolutely fine and just output a deprecation warning). The scenario identified then passed 60/60 times for me when it was flaking at least 1/10 times.

Testing

Covered by CI.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.19 kB 13.21 kB
After 43.19 kB 13.21 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 16244e0

Comment on lines +23 to +32
max_attempts = 20
attempts = 0
state = get_app_state
until (attempts >= max_attempts) || state == expected_state
attempts += 1
state = get_app_state
sleep 0.5
end
$logger.warn "App state #{state} instead of #{expected_state} after 10s" unless state == expected_state
state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is equivalent:

Suggested change
max_attempts = 20
attempts = 0
state = get_app_state
until (attempts >= max_attempts) || state == expected_state
attempts += 1
state = get_app_state
sleep 0.5
end
$logger.warn "App state #{state} instead of #{expected_state} after 10s" unless state == expected_state
state
wait = Maze::Wait.new(interval: 0.5, timeout: 10)
state = get_app_state
success = wait.until do
state = get_app_state
state == expected_state
end
$logger.warn "App state #{state} instead of #{expected_state} after 10s" unless success
state

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I shall try to remember to update this the next time I'm there, rather than suffer a full rebuild on CI right now.

Base automatically changed from bump-browser-versions to next December 8, 2022 10:02
@twometresteve twometresteve merged commit ebb4061 into next Dec 8, 2022
@twometresteve twometresteve deleted the tms/rn-maze-v7 branch December 8, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants