-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RN pipeline to use Maze Runner v7 #1886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
force-pushed
the
bump-browser-versions
branch
from
December 8, 2022 09:05
7e7ef33
to
397d735
Compare
imjoehaines
force-pushed
the
tms/rn-maze-v7
branch
from
December 8, 2022 09:07
a81c867
to
16244e0
Compare
imjoehaines
approved these changes
Dec 8, 2022
Comment on lines
+23
to
+32
max_attempts = 20 | ||
attempts = 0 | ||
state = get_app_state | ||
until (attempts >= max_attempts) || state == expected_state | ||
attempts += 1 | ||
state = get_app_state | ||
sleep 0.5 | ||
end | ||
$logger.warn "App state #{state} instead of #{expected_state} after 10s" unless state == expected_state | ||
state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is equivalent:
Suggested change
max_attempts = 20 | |
attempts = 0 | |
state = get_app_state | |
until (attempts >= max_attempts) || state == expected_state | |
attempts += 1 | |
state = get_app_state | |
sleep 0.5 | |
end | |
$logger.warn "App state #{state} instead of #{expected_state} after 10s" unless state == expected_state | |
state | |
wait = Maze::Wait.new(interval: 0.5, timeout: 10) | |
state = get_app_state | |
success = wait.until do | |
state = get_app_state | |
state == expected_state | |
end | |
$logger.warn "App state #{state} instead of #{expected_state} after 10s" unless success | |
state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I shall try to remember to update this the next time I'm there, rather than suffer a full rebuild on CI right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update RN pipeline to use Maze Runner v7.
Design
This was a fairly standard upgrade to v7, following the path already walked by the likes of bugsnag-android.
I did find, however, that at least one of the test scenarios (
Unhandled native error
) became flaky when moving to the newterminate_app
/terminate_app
Appium driver calls. This will need further investigation, so for now I have just stuck with the "old"close_app
andlaunch_app
calls (they seem to work absolutely fine and just output a deprecation warning). The scenario identified then passed 60/60 times for me when it was flaking at least 1/10 times.Testing
Covered by CI.