-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 stage builds #1997
2 stage builds #1997
Conversation
6dbc94d
to
95062ca
Compare
8497da7
to
d4a83bf
Compare
You've followed the existing pattern perfectly by putting |
|
||
if [[ "$BUILDKITE_MESSAGE" == *"[full ci]"* || | ||
"$BUILDKITE_BRANCH" == "next" || | ||
"$BUILDKITE_BRANCH" == "main" || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS is still using master
, so suggest this for future proofing:
"$BUILDKITE_BRANCH" == "main" || | |
"$BUILDKITE_BRANCH" == "main" || | |
"$BUILDKITE_BRANCH" == "master" || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, the branch name comment is the main (or do I mean master?) one to get in.
d32ef0f
to
dd9a418
Compare
Goal
Reduces CI bottlenecks by pushing the majority of React Native and RN CLI tests into a separate 'full' build pipeline
Design
Followed the same approach as the js performance repo. Full builds can be triggered for builds of
next
ormain
, with the commit message[full ci]
, or interactively via the buildkite UI.All React Native & CLI tests except those for the latest version (RN 0.72 old and new arch) have been moved to the full build.