Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Lerna bootstrap after copying packages into Docker containers #2013

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Sep 19, 2023

Goal

Fix the broken Docker image build steps.

Design

It seemed to start failing after an update to our Buildkite Elastic CI Stack for AWS:

1.506 lerna ERR! lerna EACCES: permission denied, rename '/app/packages/plugin-react-navigation/package.json' -> '/app/packages/plugin-react-navigation/package.json.lerna_backup'

I assume that a new version of Docker meant that file paths not existing in the container are not treated different. If Lerna is renaming files like then then it seems reasonable that the files should exist in the first place in the contrainer.

Changeset

Copying of packages into the containers moved to before the lerna bootstrap.

Testing

Covered by CI.

@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.67 kB 13.40 kB
After 43.67 kB 13.40 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 89ae775

@twometresteve twometresteve changed the title Tms/build issue Run Lerna bootstrap after copying packages into Docker containers Sep 19, 2023
Copy link
Member

@gingerbenw gingerbenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@twometresteve twometresteve merged commit c6927dc into next Sep 19, 2023
12 checks passed
@twometresteve twometresteve deleted the tms/build-issue branch September 20, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants