Fix errorInfo metadata in Vue 3.4+ #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
changed the title
yousif-bugsnag
force-pushed
the
vue-3-4-error-info
branch
from
6b03a6d
to
2ffaae4
Compare
gingerbenw
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In Vue 3.4+ the error handling has been updated and the info param passed to the error handler is now a link to the Vue error docs instead of a plain error code: vuejs/core@
c261bea(#9165)This breaks the
errorInfomapping in our plugin which attempts to map the error codes to message strings.This PR updates the plugin to handle the new info parameter format by attempting to extract the error code from the URL.
Testing
New unit test added, and relied on existing CI tests